feat(esx_mechanicjob): rework and rewrite by Tizas #25
Conversation
client/main.lua
Outdated
| cb(vehicle) | ||
| end) | ||
|
|
||
| Citizen.CreateThread(function() |
There was a problem hiding this comment.
Remove Citizen. you can just trigger CreateThread no need for Citizen in front of it.
client/main.lua
Outdated
| local playerPed = ESX.PlayerData.ped | ||
| local playerCoords = GetEntityCoords(playerPed) | ||
| local vehicle = ESX.Game.GetClosestVehicle(playerCoords) | ||
| if vehicle == -1 then cb(false) end |
There was a problem hiding this comment.
if not vehicle or vehicle == -1 then
return cb(false) -- return otherwise it will trigger cb(vehicle) as well
end
cb(vehicle)
There was a problem hiding this comment.
@Arctos2win ESX.Game.GetClosestVehicle will either return -1 or an entity handle. No need to check for nil
There was a problem hiding this comment.
@Arctos2win
ESX.Game.GetClosestVehiclewill either return -1 or an entity handle. No need to check for nil
didnt know the point was just the return before cb(false) otherwise cb(true) will also run even if there is no vehicle
client/modules/cloakroom.lua
Outdated
| ) | ||
| end | ||
|
|
||
| Citizen.CreateThread(function() |
There was a problem hiding this comment.
Citizen. can be removed
client/modules/npcJob.lua
Outdated
| end | ||
|
|
||
| local function EndJob() | ||
| if activeJob then |
There was a problem hiding this comment.
if not activeJob then
return ESX.ShowNotification(TranslateCap('no_active_job'))
end
client/modules/npcJob.lua
Outdated
| end | ||
|
|
||
| local function MonitorRepair() | ||
| Citizen.CreateThread(function() |
client/modules/npcJob.lua
Outdated
| return EndJob() | ||
| end | ||
| print("Player Entered Zone") | ||
| SpawnVehicle(job.vehicleCoords, job.carModel) |
There was a problem hiding this comment.
Spawn server side vehicle and add an extra step on server to check timing
|
is there anyway if i can edit this code ? and make a pr overit? |
|
@Capy1174 Once it is finished and merged, feel free to PR anything. |
No description provided.